Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support dark theme #125

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

georgesamy
Copy link
Contributor

Support dark theme for the GUI. It uses chakra-ui's built in Color Mode and Monaco Editor's theme

Note: the <SunIcon /> was used in the Donate button. I wanted to use it in the theme button so I reassigned it to <BellIcon />. Not a hard requirement but I thought it would be nicer. Open to changes.

@glassmonkey
Copy link
Owner

Thank you for your Pull Request. I appreciate your effort in contributing to the project.
I'll review it shortly and provide feedback or any necessary follow-up.

@georgesamy
Copy link
Contributor Author

Ofcourse! and thanks for creating this project, been using it for a while

@glassmonkey
Copy link
Owner

@georgesamy

Thank you your PullRequest.
I wanted to express my sincere gratitude for the feature you added.
It has significantly improved the usability of this project, making it much more comfortable to work with.

I have one small suggestion to further enhance the user experience.
Would it be possible to replace the current button with a toggle switch?

This change would make it clearer whether the button shows the current state or changes the state upon being pressed. I believe the following Pull Request might serve as a good reference for this enhancement: chakra-ui/chakra-ui#3518.

chakra-ui/chakra-ui#3518

{ (colorMode === "light") ? "Dark" : "Light" }
</Button>
<Button
leftIcon={<BellIcon />}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea!!

@georgesamy
Copy link
Contributor Author

I looked into the issue you posted and there wasn't an obvious solution. You see I'm not good on the frontend side xD
I'll try to give this another look over the next week

@glassmonkey
Copy link
Owner

thank you

@georgesamy
Copy link
Contributor Author

Ok it's done.. Also moved the switch to the top right corner.

@glassmonkey glassmonkey merged commit a3b3ffd into glassmonkey:master Feb 5, 2024
@glassmonkey
Copy link
Owner

@georgesamy

Thank you for your Pull Request! I've successfully merged it into the project. Additionally, I made some further position adjustments on our end to ensure optimal integration. Your contribution is greatly appreciated!

#134

@georgesamy georgesamy deleted the dark-theme branch February 12, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants