-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dark theme #125
Conversation
Thank you for your Pull Request. I appreciate your effort in contributing to the project. |
Ofcourse! and thanks for creating this project, been using it for a while |
Thank you your PullRequest. I have one small suggestion to further enhance the user experience. This change would make it clearer whether the button shows the current state or changes the state upon being pressed. I believe the following Pull Request might serve as a good reference for this enhancement: chakra-ui/chakra-ui#3518. |
{ (colorMode === "light") ? "Dark" : "Light" } | ||
</Button> | ||
<Button | ||
leftIcon={<BellIcon />} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice idea!!
I looked into the issue you posted and there wasn't an obvious solution. You see I'm not good on the frontend side xD |
thank you |
df6805e
to
8ae1f01
Compare
Ok it's done.. Also moved the switch to the top right corner. |
Thank you for your Pull Request! I've successfully merged it into the project. Additionally, I made some further position adjustments on our end to ensure optimal integration. Your contribution is greatly appreciated! |
Support dark theme for the GUI. It uses chakra-ui's built in Color Mode and Monaco Editor's theme
Note: the
<SunIcon />
was used in the Donate button. I wanted to use it in the theme button so I reassigned it to<BellIcon />
. Not a hard requirement but I thought it would be nicer. Open to changes.