Fix discarded bit array pattern segments resulting in unused imports

gleam-lang · Feb 10, 2025 · b011d2d · b011d2d
1 parent 255e24e
commit b011d2d
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/compiler-core/src/javascript/pattern.rs b/compiler-core/src/javascript/pattern.rs
@@ -630,6 +630,10 @@ impl<'module_ctx, 'expression_gen, 'a> Generator<'module_ctx, 'expression_gen, '
                                 }
                             }
 
+                            Pattern::Discard { .. } => {
+                                offset.increment(details.size);
+                            }
+
                             _ => {
                                 let start = offset.bits;
                                 let increment = details.size;

diff --git a/.../javascript/tests/snapshots/gleam_core__javascript__tests__bit_arrays__discard_sized.snap b/.../javascript/tests/snapshots/gleam_core__javascript__tests__bit_arrays__discard_sized.snap
@@ -11,7 +11,7 @@ fn go(x) {
 
 
 ----- COMPILED JAVASCRIPT
-import { makeError, bitArraySliceToInt } from "../gleam.mjs";
+import { makeError } from "../gleam.mjs";
 
 function go(x) {
   if (!(x.bitSize == 24)) {

diff --git a/...ript/tests/snapshots/gleam_core__javascript__tests__bit_arrays__match_bits_with_size.snap b/...ript/tests/snapshots/gleam_core__javascript__tests__bit_arrays__match_bits_with_size.snap
@@ -10,7 +10,7 @@ fn go(x) {
 
 
 ----- COMPILED JAVASCRIPT
-import { makeError, toBitArray, bitArraySlice, bitArraySliceToInt, sizedInt } from "../gleam.mjs";
+import { makeError, toBitArray, bitArraySlice, sizedInt } from "../gleam.mjs";
 
 function go(x) {
   let $ = toBitArray([sizedInt(0x77, 7, true)]);

diff --git a/...tests/snapshots/gleam_core__javascript__tests__bit_arrays__match_rest_bits_unaligned.snap b/...tests/snapshots/gleam_core__javascript__tests__bit_arrays__match_rest_bits_unaligned.snap
@@ -10,7 +10,7 @@ fn go(x) {
 
 
 ----- COMPILED JAVASCRIPT
-import { makeError, toBitArray, bitArraySlice, bitArraySliceToInt } from "../gleam.mjs";
+import { makeError, toBitArray, bitArraySlice } from "../gleam.mjs";
 
 function go(x) {
   let $ = toBitArray([1, 2, 3]);