Implement Code Action to Generate JSON Encoder #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Feb 11, 2025
| option.Some(value) -> json.int(value) | ||
| }), | ||
| #("something", todo as "Encoder for Something"), | ||
| #("map", json.dict(wibble.map, fn(string) { string }, json.array(_, json.float(_)))), |
There was a problem hiding this comment.
Suggested change
| #("map", json.dict(wibble.map, fn(string) { string }, json.array(_, json.float(_)))), | |
| #("map", json.dict(wibble.map, fn(string) { string }, json.array(_, json.float))), |
🙏
There was a problem hiding this comment.
Yep, that's fair. That was a bit I was a little iffy on
|
Ah, I've just found a bug. Let me fix that quickly |
|
ack, merge conflicts! |
|
Yep. I'm out at the moment, I'll resolve them when I get home |
|
I'm on it 😎 |
lpil
force-pushed
the
generate-json-encoder
branch
from
5182922 to
76a0171
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4227
This is basically a copy-paste-change of the generate dynamic decoder action.