Fix convert to call #4237
Merged
Fix convert to call #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Feb 12, 2025
compiler-core/src/ast/typed.rs
Outdated
| /// // ^^^^^^ module_location | ||
| /// ``` | ||
| /// | ||
| module_location: SrcSpan, |
There was a problem hiding this comment.
The second int is redundant, it is the same as the first int in location.
Perhaps we want to have location be the whole thing and then have a field_start or something which is the location of the first character after the .? Would be nice to have the warning and errors from from after the dot rather than on it too so you don't have to press right after jumping to the error to fix it.
There was a problem hiding this comment.
I would love for the location to cover the entire field, I've always found it a bit odd that the module selection location doesn't cover the whole thing, and it means we always have to special case those in code actions that need to work on their entire span. I'll try and fix it!
I incorrectly used the location of the whole "label + discard hole" as the hole location, this meant that when removing a pipe and inserting the value on the left of the `|>` in the hole I'd overwrite the label as well
when a field access can't be inferred the invalid expression now cover the entire thing instead of just the label part, that was previously excluded
only the part after the `.` would be moved into the function call. Now we keep track of the entire srcspan of the module select so we can move the entire thing including the module before `.`
lpil
force-pushed
the
fix-convert-to-call
branch
from
cbde505 to
8a6ca7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple of bugs in the "convert to call" code action testing it out on some real code:
..This PR fixes all of those issues