Bump protobuf to 3.7.1 and regenerate code from .proto files #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diemogebhardt
commented
Jan 30, 2025
| @@ -27,7 +27,7 @@ regex = "1.3" | |||
| # Byte collections | |||
| bytes = "1" | |||
| # Protobuf runtime | |||
| protobuf = "3.4" | |||
| protobuf = "=3.7.1" | |||
There was a problem hiding this comment.
Do we want to pin protobuf and protobuf-codegen to a specific version (=) or not?
In case we don't want to pin it, we should uncomment the code in build.rs that is responsible for regenerating code from .proto files.
diemogebhardt
commented
Jan 30, 2025
| @@ -53,4 +53,4 @@ toml = "0.8" | |||
|
|
|||
| [build-dependencies] | |||
| # Protobuf code generation | |||
| protobuf-codegen = "3.4" | |||
| protobuf-codegen = "=3.7.1" | |||
There was a problem hiding this comment.
Do we want to pin protobuf and protobuf-codegen to a specific version (=) or not?
In case we don't want to pin it, we should uncomment the code in build.rs that is responsible for regenerating code from .proto files.
This was referenced Jan 30, 2025
Merged
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
protobufandprotobuf-codegento the latest version (3.7.1) and regenerates code from .proto files.