Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bad test case #497

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

ilaumjd
Copy link
Contributor

@ilaumjd ilaumjd commented Aug 16, 2024

Description:

  • Tasks solved
    One bad test case query_without_code_or_pre_block where it is comparing hardcoded string into howdoi search result which can be changing anytime.
    Please check @gleitz

Pull Request type:

  • Test fix

How to test:

Please provide detailed instructions for testing your changes locally, including expected response/behavior.

Pull Request checklist:

  • Read the contributing_to_howdoi.md
  • Attach screenshots of expected behavior.
  • The changes pass tests locally (nose2).
  • There are no linting errors (python setup.py lint).
  • The changes don't break existing features.
  • Check that there are no confidential files like .env included.
  • Request review from the maintainers.
  • For bug fixes or changes to directory structure, make sure docs are updated.

Known bugs (if any):

If there are bugs in your current changes you can still open the PR and mention the bugs you found. Propose further changes that can help fix bugs in your current changes.

@gleitz gleitz merged commit af1ce83 into gleitz:master Aug 16, 2024
5 checks passed
@gleitz
Copy link
Owner

gleitz commented Aug 16, 2024

Thanks! Hard to keep up with the top answer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants