Increasing test coverage #3104
Merged
Increasing test coverage #3104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akanshaaa19
changed the title
|
🚀 Deployed on https://deploy-preview-3104--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3104 +/- ##
==========================================
+ Coverage 80.97% 81.45% +0.47%
==========================================
Files 323 320 -3
Lines 10351 10281 -70
Branches 2198 2187 -11
==========================================
- Hits 8382 8374 -8
+ Misses 1340 1300 -40
+ Partials 629 607 -22 ☔ View full report in Codecov by Sentry. |
Glific
|
||||||||||||||||||||||||||||
| Project |
Glific
|
| Branch Review |
fix/test-cases
|
| Run status |
|
| Run duration | 25m 28s |
| Commit |
|
| Committer | Akansha Sakhre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
169
|
| View all changes introduced in this branch ↗︎ | |
akanshaaa19
changed the title
kurund
reviewed
Nov 4, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "semi": true, | |||
| "printWidth": 100, | |||
There was a problem hiding this comment.
any specific reason for this change?
There was a problem hiding this comment.
the test coverage for AuthenticatedRoute file was not covering all lines because it was going to the next line
yarn.lock
Outdated
| @@ -5514,8 +5514,16 @@ streamx@^2.12.0, streamx@^2.12.5, streamx@^2.13.2, streamx@^2.14.0: | |||
| optionalDependencies: | |||
| bare-events "^2.2.0" | |||
|
|
|||
| "string-width-cjs@npm:string-width@^4.2.0", string-width@^4.1.0: | |||
| name string-width-cjs | |||
| "string-width-cjs@npm:string-width@^4.2.0": | |||
kurund
requested changes
Nov 7, 2024
src/containers/SettingList/OrganizationFlows/OrganisationFLows.test.tsx
Outdated
Show resolved
Hide resolved
| @@ -152,6 +152,95 @@ export const FormLayout = ({ | |||
| const [showConfirmationDialog, setShowConfirmationDialog] = useState(false); | |||
| const params = useParams(); | |||
|
|
|||
| const saveHandler = ({ languageId: languageIdValue, ...itemData }: any) => { | |||
There was a problem hiding this comment.
any reason for moving these 2 function around?
There was a problem hiding this comment.
earlier it was used before its declaration, which raised an error sometimes
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.