Adds subscription for contacts on chat page #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
- Coverage 68.65% 68.08% -0.58%
==========================================
Files 77 77
Lines 1171 1178 +7
Branches 97 101 +4
==========================================
- Hits 804 802 -2
- Misses 340 348 +8
- Partials 27 28 +1
☔ View full report in Codecov by Sentry. |
mdshamoon
requested changes
Aug 2, 2023
screens/Chat.tsx
Outdated
| @@ -1,4 +1,5 @@ | |||
| import React, { useState, useEffect } from 'react'; | |||
| /* eslint-disable prettier/prettier */ | |||
There was a problem hiding this comment.
It was added by mistake, I removed it in the latest changes
screens/Chat.tsx
Outdated
Comment on lines
28
to
32
| switch (action) { | ||
| case 'RECEIVED': | ||
| contactId = subscriptionData.data.receivedMessage.contact.id; | ||
| id = subscriptionData.data.receivedMessage.id; | ||
| body = subscriptionData.data.receivedMessage.body; |
There was a problem hiding this comment.
I think this is similar to what we have done in message list. Can you create a common functiona and use in both places.
|
@VishalZ123 can you please fix all deep scan problems first. |
mdshamoon
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds subscriptions for contacts message on chat page
Summary
This adds the feature of updating the contact card on the chat screen when a user sends or receives messages.
Changes made
MESSAGE_RECEIVED_SUBSCRIPTION&MESSAGE_RECEIVED_SUBSCRIPTIONsubscriptions.Issues
Closes: #139
@mdshamoon Please review this PR.