Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Contact Information and History #153

Merged
merged 15 commits into from
Aug 9, 2023
Merged

Conversation

VishalZ123
Copy link
Collaborator

@VishalZ123 VishalZ123 commented Aug 5, 2023

Dynamic Contact Info and History

Summary
Implements the dynamic contact info and history. Uses GET_CONTACT_INFO for fetching the contact information, formats it and displays. More info option displays the fields for the contact. Contact History option displays all the action taken for the contact, using the GET_CONTACT_HISTORY query.

Changes Made

  • Implements dynamic contact information
  • Adds More info page that displays the fields for the contacts
  • Adds the Contact History page that displays the history actions of a contact
  • Load more history on scroll
  • Adds tests and mocks for unit testing
contact-info.mp4

Issues

Closes: #140

Reviewers
@mdshamoon , Kindly review and merge

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 88.13% and project coverage change: +1.01% 🎉

Comparison is base (9d2a8c7) 68.17% compared to head (a122a3c) 69.18%.
Report is 12 commits behind head on main.

❗ Current head a122a3c differs from pull request most recent head 51f53bf. Consider uploading reports for the commit 51f53bf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   68.17%   69.18%   +1.01%     
==========================================
  Files          77       77              
  Lines        1172     1217      +45     
  Branches       98      101       +3     
==========================================
+ Hits          799      842      +43     
+ Misses        348      345       -3     
- Partials       25       30       +5     
Files Changed Coverage Δ
config/apollo.ts 0.00% <0.00%> (ø)
screens/ContactHistory.tsx 85.71% <83.33%> (-4.29%) ⬇️
graphql/queries/Contact.ts 100.00% <100.00%> (ø)
screens/ContactInfo.tsx 100.00% <100.00%> (ø)
screens/ContactProfile.tsx 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VishalZ123 VishalZ123 requested a review from mdshamoon August 5, 2023 05:32
@ajaman190
Copy link
Collaborator

Hey @VishalZ123, please resolve all the deep scan issues.

@mdshamoon mdshamoon merged commit d8b86ff into main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make view contact info and history dynamic
3 participants