Restore a working linking setup #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
added a commit
to emberjs/ember.js
that referenced
this pull request
Dec 8, 2023
chancancode
force-pushed
the
yalc-shave
branch
4 times, most recently
from
2108ba1 to
2074df6
Compare
|
In hindsight, it may be nice to integrate or do some parts of this as a rollup plugin in the existing build pipeline, so that the |
The purpose of this is to restore a working setup where we can link all glimmer-vm to ember.js without publishing. Previously this was just a script that `yarn link` on both sides. It seems like we tried to use `yalc` at some point. Neither of those other solutions fully works with the constraints: * supports pnpm * supports pnpm workspace * supports `publishConfig` * resolve internal dependencies (like `@glimmer/encoder`) when linked This script makes it work with all of the above. Usage: 1. pnpm install, develop, make changes, etc 2. pnpm build 3. pnpm link:all 4. pnpm link:glimmer-vm from ember.js 5. validate, iterate, re-run pnpm build/pnpm link:all as needed 6. pnpm unlink from ember.js 7. pnpm unlink:all here See also emberjs/ember.js#20590
chancancode
force-pushed
the
yalc-shave
branch
from
2074df6 to
5e01dba
Compare
|
|
||
| await unlink(tarball); | ||
|
|
||
| // https://github.com/pnpm/pnpm/issues/881 |
There was a problem hiding this comment.
thanks for leaving this link here!
NullVoxPopuli
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen_Recording_2023-12-08_at_2.53.28_PM.mov
The purpose of this is to restore a working setup where we can link all glimmer-vm to ember.js without publishing.
Previously this was just a script that
yarn linkon both sides.It seems like we tried to use
yalcat some point.Neither of those other solutions fully works with the constraints:
publishConfig@glimmer/encoder) when linkedThis script makes it work with all of the above.
Usage:
See also emberjs/ember.js#20590