Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split 'show boosts/replies in public timelines' glitch admin setting into local and federated (neatchee/mastodon#8) #2054

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

neatchee
Copy link

Showing all federated boosts is noisy while local boosts may be acceptable (especially once neatchee#4 is addressed)

deanveloper and others added 4 commits December 29, 2022 20:04
… into local and federated (#8)

* Showing all federated boosts is noisy while local boosts may be acceptable (especially once #4 is addressed)
Copy link

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing changes in config/settings.yml to change the defaults. In addition, it's pretty minor, but I'd like to have the current setting be automatically migrated to the newer ones… but on this, while this can be done and has been done is the past (see db/migrate/20190314181829_migrate_open_registrations_setting.rb) I'm not super comfortable manipulating Settings like that either. Though I guess this can be revisited in the future if we drop or update the settings gem.

app/services/fan_out_on_write_service.rb Outdated Show resolved Hide resolved
@neatchee
Copy link
Author

neatchee commented Jan 4, 2023

Alrighty, that should cover all the feedback :)
I don't especially like changing settings that way either but we don't really have much choice in this scenario

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants