-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split 'show boosts/replies in public timelines' glitch admin setting into local and federated (neatchee/mastodon#8) #2054
base: main
Are you sure you want to change the base?
Conversation
…nto split_public_visible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is missing changes in config/settings.yml
to change the defaults. In addition, it's pretty minor, but I'd like to have the current setting be automatically migrated to the newer ones… but on this, while this can be done and has been done is the past (see db/migrate/20190314181829_migrate_open_registrations_setting.rb
) I'm not super comfortable manipulating Settings
like that either. Though I guess this can be revisited in the future if we drop or update the settings gem.
Co-authored-by: Claire <[email protected]>
…s in local/federated timelines
Alrighty, that should cover all the feedback :) |
This pull request has merge conflicts that must be resolved before it can be merged. |
Showing all federated boosts is noisy while local boosts may be acceptable (especially once neatchee#4 is addressed)