Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #287 (hopefully)
Of course we need to add tests. Before that:
When user click on
update
he is updating a single image, hence I am not allowing him to select multiple images. However, I am using an array ofActionDispatch::Request
so that we can use same functionsatellite_commit
. Am I right?When user update an
image1.jpg
withimage2.jpg
. We keep both copies ofimage1
andimage2
in tree. Shouldn't we removeimage1.jpg
from tree?Can I take up Validate file uploads #220? We already have Fixed update option #236 but there seems to be no activity on it. Validate file uploads #220 needs to be fixed for me to write tests.
#Need_Feedback