Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #287: update image working #289

Closed
wants to merge 1 commit into from

Conversation

sonalkr132
Copy link
Collaborator

closes #287 (hopefully)

Of course we need to add tests. Before that:

  • When user click on update he is updating a single image, hence I am not allowing him to select multiple images. However, I am using an array of ActionDispatch::Request so that we can use same function satellite_commit. Am I right?

  • When user update an image1.jpg with image2.jpg. We keep both copies of image1 and image2 in tree. Shouldn't we remove image1.jpg from tree?

  • Can I take up Validate file uploads #220? We already have Fixed update option #236 but there seems to be no activity on it. Validate file uploads #220 needs to be fixed for me to write tests.

    #Need_Feedback

sonalkr132 referenced this pull request in sonalkr132/GlitterGallery Apr 15, 2015
@sonalkr132
Copy link
Collaborator Author

Fixed in #292

@sonalkr132 sonalkr132 closed this May 6, 2015
@sonalkr132 sonalkr132 deleted the update_image branch November 9, 2015 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File update method in projects controller
1 participant