Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Upload and Download Artifact Versions #1199

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Update Upload and Download Artifact Versions #1199

merged 4 commits into from
Jan 16, 2024

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR updates the upload and download artifact actions to version 4 properly.

Motivation and Context

The new versions were reverted in #1196 after being bumped improperly in #1190 and #1191 .

How Has This Been Tested?

If CI passes, we are good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann tommy-waltmann marked this pull request as ready for review January 12, 2024 17:41
@tommy-waltmann tommy-waltmann requested a review from a team as a code owner January 12, 2024 17:41
@tommy-waltmann tommy-waltmann requested review from vyasr and removed request for a team January 12, 2024 17:41
joaander
joaander approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I checked the TestPyPI build logs and it appears to be attempting uploads of all the wheels as it should.

@tommy-waltmann tommy-waltmann merged commit 84e0aa1 into master Jan 16, 2024
22 checks passed
@tommy-waltmann tommy-waltmann deleted the fix-build-wheels branch January 16, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaander joaander joaander approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr was automatically assigned from glotzerlab/freud-maintainers

Assignees
No one assigned
Labels
build_wheels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommy-waltmann @joaander