Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more features of unittest #156

Closed
wants to merge 6 commits into from
Closed

Use more features of unittest #156

wants to merge 6 commits into from

Conversation

cbkerr
Copy link
Member

@cbkerr cbkerr commented Oct 26, 2022

Description

Motivation and Context

Trying to make it easier to add tests to our PRs #155, #152, #132 .

Checklist:

@cbkerr cbkerr requested review from bdice and a team as code owners October 26, 2022 03:31


class AllModulesTestCase(DashboardTestCase):
"""Add all modules and contexts and test again."""

# todo, keep just the module initialization and move the duplicate code away
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like help refactoring this.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #156 (abebc3d) into master (1315fbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   72.40%   72.40%           
=======================================
  Files          20       20           
  Lines         750      750           
=======================================
  Hits          543      543           
  Misses        207      207           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bdice
Copy link
Member

bdice commented Oct 26, 2022

Rather than doubling down on unittest paradigms here, I'd recommend porting our tests to use pytest. pytest has helpful error messages for plain assert statements.

@b-butler b-butler removed the request for review from a team November 22, 2022 21:08
@bdice
Copy link
Member

bdice commented Dec 3, 2022

@cbkerr I'm going to close this PR. If we were to apply these changes, it would actually move us away from pytest API design / paradigms, which we want to embrace. I haven't had time to migrate the testing suite fully to pytest, but it is an eventual task that I plan to take on after cleaning up some of the backlog of signac 2.0 and signac-dashboard 0.4.0 work. I opened #164 to track this.

@bdice bdice closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants