-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more features of unittest #156
Conversation
for more information, see https://pre-commit.ci
|
||
|
||
class AllModulesTestCase(DashboardTestCase): | ||
"""Add all modules and contexts and test again.""" | ||
|
||
# todo, keep just the module initialization and move the duplicate code away |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like help refactoring this.
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=======================================
Coverage 72.40% 72.40%
=======================================
Files 20 20
Lines 750 750
=======================================
Hits 543 543
Misses 207 207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
for more information, see https://pre-commit.ci
Rather than doubling down on |
@cbkerr I'm going to close this PR. If we were to apply these changes, it would actually move us away from pytest API design / paradigms, which we want to embrace. I haven't had time to migrate the testing suite fully to pytest, but it is an eventual task that I plan to take on after cleaning up some of the backlog of signac 2.0 and signac-dashboard 0.4.0 work. I opened #164 to track this. |
Description
assertTrue
as recommended in examples (may switch to more specificassertIn
for some)Motivation and Context
Trying to make it easier to add tests to our PRs #155, #152, #132 .
Checklist: