Fix packaging script files for CLI #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-butler
requested review from
mikemhenry and
pepak13
and removed request for
a team
mikemhenry
approved these changes
Sep 15, 2023
Codecov Report
@@ Coverage Diff @@
## main #765 +/- ##
==========================================
+ Coverage 69.28% 69.33% +0.05%
==========================================
Files 43 44 +1
Lines 4294 4295 +1
Branches 1047 1047
==========================================
+ Hits 2975 2978 +3
+ Misses 1108 1107 -1
+ Partials 211 210 -1
|
mikemhenry
reviewed
Sep 15, 2023
mikemhenry
reviewed
Sep 15, 2023
mikemhenry
reviewed
Sep 15, 2023
mikemhenry
previously requested changes
Sep 15, 2023
Co-authored-by: Mike Henry <[email protected]>
|
@mikemhenry thanks for the catch. |
Co-authored-by: Mike Henry <[email protected]>
bdice
requested changes
Sep 18, 2023
| # Copyright (c) 2023 The Regents of the University of Michigan | ||
| # All rights reserved. | ||
| # This software is licensed under the BSD 3-Clause License. | ||
| """Import command line scripts.""" |
There was a problem hiding this comment.
Can we add very basic CLI tests? Even just flow --help. See signac for an example of this.
There was a problem hiding this comment.
We have these tests see https://github.com/glotzerlab/signac-flow/blob/main/tests/test_shell.py.
My guess is that tests are run in the repo directory which has the file but the install doesn't due to setuptools package detection requiring an __init__.py.
There was a problem hiding this comment.
This is why I run tests on installed packages without any source directory. Too many issues like this can occur.
bdice
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the necessary
__init__.pyfile.Motivation and Context
Version 0.26.0 is broken when installing.
Resolves: #763
Checklist: