-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider regex match when issuing "unrecognized flow operation warning. #804
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 69.27% 69.43% +0.16%
==========================================
Files 48 48
Lines 4397 4391 -6
Branches 1065 1062 -3
==========================================
+ Hits 3046 3049 +3
+ Misses 1142 1135 -7
+ Partials 209 207 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice quality of life improvement.
Description
Evaluate regex matches for operation/group names first, then issue a warning when there are no matches.
Motivation and Context
Previously, flow would issue warnings for all regex names as they do not exactly match the name of any group. This code demonstrates:
The output before the changes includes
op.*
which matchesoperation
.The output after the changes includes only names that do not match.
Checklist: