Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-arm64 runners. #806

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Use macos-arm64 runners. #806

merged 4 commits into from
Feb 5, 2024

Conversation

joaander
Copy link
Member

@joaander joaander commented Feb 2, 2024

Description

Use the new GitHub Actions macos-arm64 runners.

Motivation and Context

Decrease the time needed to complete CI checks.

Checklist:

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da6fc8f) 69.27% compared to head (d8f0783) 69.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #806   +/-   ##
=======================================
  Coverage   69.27%   69.27%           
=======================================
  Files          48       48           
  Lines        4397     4397           
  Branches     1065     1065           
=======================================
  Hits         3046     3046           
  Misses       1142     1142           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cbkerr cbkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cbkerr
Copy link
Member

cbkerr commented Feb 2, 2024

Looks like they only support back to python 3.10 on arm64

Run actions/setup-python@v4
Installed versions
  Version 3.9 was not found in the local cache
  Error: The version '3.9' with architecture 'arm64' was not found for macOS 14.2.1.
  The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json

@joaander
Copy link
Member Author

joaander commented Feb 2, 2024

47 minutes down to 42. Why does pytest take so long on Macs?

@joaander
Copy link
Member Author

joaander commented Feb 5, 2024

Looking at some slow tests:

  • test_process_parallelized_project_status_homogeneous_schema spends 10 seconds inside <method 'acquire' of '_thread.lock' objects>.
  • test_run_order, test_submit_status, and others spend all their time in built-in method posix.waitpid` (~10 seconds per call).

While these are running, there is very little CPU activity measured in htop. It seems that there might be a 10 second timeout somewhere that every one of these tests is triggering? In any case, this PR does not create the issue. I will investigate further at a later time.

@joaander joaander marked this pull request as ready for review February 5, 2024 13:33
@joaander joaander requested review from a team as code owners February 5, 2024 13:33
@joaander joaander requested review from bdice and SchoeniPhlippsn and removed request for a team February 5, 2024 13:33
@joaander joaander enabled auto-merge (squash) February 5, 2024 14:02
@joaander joaander merged commit 1d0f9fd into main Feb 5, 2024
12 checks passed
@joaander joaander deleted the use-macos-arm64-runners branch February 5, 2024 19:38
@cbkerr cbkerr added this to the 0.28.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants