-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve aggregation and status performance (no conditions). #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows faster `job in project` tests and iteration over jobs. Also remove some expensive open_job calls and job in project checks that are not needed while registering aggregates.
…ned. This saves a small amount of absolute time in projects with no labels. It also gives the *appearance* of faster status checks as the user sees only 1 progress bar. Also, hide the "labels" section of the status output when there are no labels to show.
joaander
force-pushed
the
improve-performance
branch
from
February 15, 2024 16:27
abf7ccd
to
7be27f8
Compare
joaander
requested review from
kidrahahjo and
tommy-waltmann
and removed request for
a team
February 15, 2024 16:37
bdice
approved these changes
Feb 15, 2024
tommy-waltmann
approved these changes
Feb 15, 2024
cbkerr
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cached_statepoint
in aggregators._buffered
and avoid filesystem checks during aggregation and status check loops.This first pass is tested against workflows with no pre/post conditions. I have plans to optimize
[pre/post].isfile
in a later PR.Motivation and Context
Significantly improve the performance of common flow operations, especially workspaces with many jobs and aggregates.
Here are benchmark results performed on the Great Lakes scratch filesystem with 100k jobs.
signac 2.2.0, flow main:
signac 2.2.0, flow ce37f01
All benchmarks run after
signac update-cache
.Checklist: