Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in schema code #540

Merged
merged 3 commits into from
May 6, 2021
Merged

Fix bugs in schema code #540

merged 3 commits into from
May 6, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 25, 2021

Description

This PR fixes some minor issues I found while implementing glotzerlab/signac-flow#504.

Motivation and Context

These bug fixes have no impact right now because migrations are not enabled, but they will be needed once the migration code path is activated.

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog and added all related issue and pull request numbers for future reference (if applicable). See example below.

I don't think a changelog entry is warranted for this PR.

@vyasr vyasr requested review from a team as code owners April 25, 2021 18:09
@vyasr vyasr requested review from bdice and andkerr and removed request for a team April 25, 2021 18:09
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #540 (5784952) into master (ff208cf) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 5784952 differs from pull request most recent head fccb4cf. Consider uploading reports for the commit fccb4cf to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   78.27%   78.27%           
=======================================
  Files          65       65           
  Lines        7069     7069           
  Branches     1311     1311           
=======================================
  Hits         5533     5533           
  Misses       1231     1231           
  Partials      305      305           
Impacted Files Coverage Δ
signac/__main__.py 71.89% <ø> (ø)
signac/contrib/migration/__init__.py 82.45% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff208cf...fccb4cf. Read the comment docs.

@andkerr andkerr removed their request for review May 3, 2021 13:32
@bdice bdice enabled auto-merge (squash) May 6, 2021 15:50
@bdice bdice merged commit 7c0e54a into master May 6, 2021
@bdice bdice deleted the fix/schema_update_bugs branch May 6, 2021 17:07
@b-butler b-butler added this to the 1.7.0 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants