Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy way of processing the data using a function pointer #10

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

dcalogue
Copy link

This way we can supply the library with a function pointer where we will process the data received.
This should allow anyone to use the library without modifiyng it on a per project basis.

@jersey99
Copy link
Contributor

Thanks for the PR. The change looks good! I will test it sometime this week, and if it works I will merge it.

@jhlink
Copy link

jhlink commented Nov 22, 2016

This seems so crazy stupid simple...
I'll check with @jersey99 as well.

@jersey99
Copy link
Contributor

@jhlink What do you mean by "this seems so crazy stupid simple .."? And what do you mean by you will check with me?

@jhlink
Copy link

jhlink commented Nov 22, 2016

Haha, sorry @jersey99 for the miscommunication. :)

Using function pointers has never crossed my mind. This is something I've come across frequently in node, but I've never really seen it used in C++ or considered using in C++.

Instead of using "checking," I should have used "trying." I've got some extra Photons lying around, and was going to try out this PR on them. Super excited to see how function pointers will work in this library!

@rlogiacco
Copy link

this PR has been left pending for more than 2 years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants