Fix tickets users added after webhook filter check #18391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it should be just before or just after the call to the item_add plugin hook to also account for Infocom stuff. |
cconard96
approved these changes
Nov 27, 2024
Rom1-B
suggested changes
Nov 27, 2024
Co-authored-by: Romain B. <[email protected]>
cedric-anne
approved these changes
Dec 2, 2024
|
Tests are failing, please fix them. |
cedric-anne
requested review from
trasher,
cedric-anne and
AdrienClairembault
cedric-anne
approved these changes
Dec 3, 2024
AdrienClairembault
approved these changes
Dec 3, 2024
Rom1-B
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
In the webhook filters, when targeting ticket creations (e.g., "Technician assigned is Jon Doe"), the webhook is not triggered for a ticket that meets the valid conditions.
The issue lies in the fact that post_add elements (such as adding a user to the ticket) are processed only after the filtering criteria are evaluated to determine whether the webhook should be triggered.
Screenshots (if appropriate):