Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule ticket): standardization of actions on groups #18394

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat(rule ticket): standardization of actions on groups #18394

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92a0867
feat(rule ticket): standardization of actions on groups
Rom1-B Nov 27, 2024
2af53bf
fromitem + regex_result
Rom1-B Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 56 additions & 2 deletions src/RuleTicket.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,18 @@ public function executeActions($output, $params, array $input = [])
) {
$output['_groups_id_requester'] = $output['users_default_groups'];
}
if (
( $action->fields['field'] == '_groups_id_observer')
&& isset($output['users_default_groups'])
) {
$output['_groups_id_observer'] = $output['users_default_groups'];
}
if (
( $action->fields['field'] == '_groups_id_assign')
&& isset($output['users_default_groups'])
) {
$output['_groups_id_assign'] = $output['users_default_groups'];
}
break;

case 'fromitem':
Expand All @@ -357,6 +369,18 @@ public function executeActions($output, $params, array $input = [])
) {
$output['_groups_id_requester'] = $output['_groups_id_of_item'];
}
if (
$action->fields['field'] == '_groups_id_observer'
&& isset($output['_groups_id_of_item'])
) {
$output['_groups_id_observer'] = $output['_groups_id_of_item'];
}
if (
$action->fields['field'] == '_groups_id_assign'
&& isset($output['_groups_id_of_item'])
) {
$output['_groups_id_assign'] = $output['_groups_id_of_item'];
}
break;

case 'compute':
Expand Down Expand Up @@ -454,6 +478,36 @@ public function executeActions($output, $params, array $input = [])
$output['_additional_groups_requesters'][$group->getID()] = $group->getID();
}
}
} else if ($action->fields["field"] == "_groups_id_observer") {
foreach ($this->regex_results as $regex_result) {
$regexvalue = RuleAction::getRegexResultById(
$action->fields["value"],
$regex_result
);
$group = new Group();
if (
$group->getFromDBByCrit(["name" => $regexvalue,
"is_observer" => true
])
) {
$output['_additional_groups_observers'][$group->getID()] = $group->getID();
}
}
} else if ($action->fields["field"] == "_groups_id_assign") {
foreach ($this->regex_results as $regex_result) {
$regexvalue = RuleAction::getRegexResultById(
$action->fields["value"],
$regex_result
);
$group = new Group();
if (
$group->getFromDBByCrit(["name" => $regexvalue,
"is_assign" => true
])
) {
$output['_additional_groups_assigns'][$group->getID()] = $group->getID();
}
}
}

if ($action->fields["field"] == "assign_appliance") {
Expand Down Expand Up @@ -846,7 +900,7 @@ public function getActions()
$actions['_groups_id_assign']['name'] = __('Technician group');
$actions['_groups_id_assign']['type'] = 'dropdown';
$actions['_groups_id_assign']['condition'] = ['is_assign' => 1];
$actions['_groups_id_assign']['force_actions'] = ['assign', 'append'];
$actions['_groups_id_assign']['force_actions'] = ['assign', 'append', 'fromitem', 'defaultfromuser','regex_result'];
$actions['_groups_id_assign']['permitseveral'] = ['append'];
$actions['_groups_id_assign']['appendto'] = '_additional_groups_assigns';

Expand All @@ -871,7 +925,7 @@ public function getActions()
$actions['_groups_id_observer']['name'] = _n('Watcher group', 'Watcher groups', 1);
$actions['_groups_id_observer']['type'] = 'dropdown';
$actions['_groups_id_observer']['condition'] = ['is_watcher' => 1];
$actions['_groups_id_observer']['force_actions'] = ['assign', 'append'];
$actions['_groups_id_observer']['force_actions'] = ['assign', 'append', 'fromitem', 'defaultfromuser','regex_result'];
$actions['_groups_id_observer']['permitseveral'] = ['append'];
$actions['_groups_id_observer']['appendto'] = '_additional_groups_observers';

Expand Down