Add 3rd set of illustrations #18420
Merged
Add 3rd set of illustrations #18420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orthagh
approved these changes
Nov 29, 2024
trasher
approved these changes
Dec 2, 2024
cedric-anne
reviewed
Dec 2, 2024
Comment on lines
+100
to
+108
| if (!str_contains($rendered_icon, 'var(--tblr-primary)')) { | ||
| $errors[] = "The '$filename' illustration is missing the primary color."; | ||
| } | ||
| if (!str_contains($rendered_icon, 'var(--tblr-primary)')) { | ||
| $errors[] = "The '$filename' illustration is missing the main menu color."; | ||
| } | ||
| if (!str_contains($rendered_icon, 'var(--tblr-primary)')) { | ||
| $errors[] = "The '$filename' illustration is missing the header color."; | ||
| } |
There was a problem hiding this comment.
These 3 checks are identical.
There was a problem hiding this comment.
Indeed, will be fixed here: #18440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
3rd set of illustration made by Pablo.
I've also modified the tests to make errors more readable and make sure it report all errors at once instead of stopping at the first invalid icon.