Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabled loading of FXML files via drag&drop to WelcomeScreen. #591

Closed
wants to merge 13 commits into from

Conversation

Oliver-Loeffler
Copy link
Collaborator

@Oliver-Loeffler Oliver-Loeffler commented Oct 20, 2022

This feature PR introduces drag&drop to the welcome page.
One now can select a group of files and directories and drag them over the welcome page. On drop, the files are filtered to be FXML files and dropped subdirectories are searched for FXML files in first level.

All FXML files found will be passed to the file open process of Scene Builder.
For unsupported files or empty directories no message will be displayed as long as at least one file can be loaded.

If no file can be loaded at all, a message is displayed to the user that there were either unsupported files and/or the selected directories did not contain any supported file.

Issue

Fixes #584

Progress

@abhinayagarwal abhinayagarwal self-requested a review November 7, 2022 11:52
@abhinayagarwal
Copy link
Collaborator

abhinayagarwal commented Nov 7, 2022

Can we also make sure that Scene Builder doesn't exit if an invalid FXML is dropped or opened?

@Oliver-Loeffler
Copy link
Collaborator Author

Oliver-Loeffler commented Nov 7, 2022 via email

@Oliver-Loeffler
Copy link
Collaborator Author

Oliver-Loeffler commented Nov 7, 2022

Hi @abhinayagarwal,

Thanks for reviewing. I was wrong with my previous statement and after some reading #585 turned out to be the relevant PR for this. Please have a look at PR #585, this one exactly addresses the issue of error reporting and keeping the Welcome Page open. Its a bit more complex but this is IMHO a good basis for #591. Both combined work quite well.

My proposal is to merge PR #585 first, then get the drag&drop one merged.
Looking forward to your feedback regarding #585.

@abhinayagarwal abhinayagarwal added this to the 22 milestone Sep 25, 2023
@Oliver-Loeffler Oliver-Loeffler deleted the issue-584 branch August 26, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome Page should support loading FXMLs via drag&drop
3 participants