Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Publisher field #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ifohancroft
Copy link
Contributor

@ifohancroft ifohancroft commented Sep 9, 2021

I've added a Publisher field (XMP-dc Publisher and PDF-Info Producer).
Closes #20

@ifohancroft
Copy link
Contributor Author

ifohancroft commented Apr 6, 2022

I noticed yesterday that I didn't initially add the new UI field to the table in the README, so I updated the PR to include that change as well.

P.S. What is the idea behind var_unset() on line 136 in pdfmted-editor?

I noticed you unset some variables there and I thought I need to add the publisher variable in there as well, however, I noticed you don't unset all the variables that a document uses there.
So, what is the idea behind it? Did you forget to add the other variables, or is there a reason only KEYWORDS, SUBJECT, AUTHOR, TITLE_FNN and UPDATED_NAME are being unset there?

Do I need to add PUBLISHER there as well?

@ifohancroft
Copy link
Contributor Author

Hey! It's been a while. How are you doing?

Just wanted to remind you of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Allow for a Publisher field
1 participant