Add mtz support and PDB Search #59
Conversation
|
This will need a test before merge |
Changed folder structure Changed mainline components to use props and spreader Extrapolated common functions
|
Just completed a major refactor so this testing is even more important now.
|
|
|
||
| useEffect( () => { | ||
| if (pdb.length != 4) { return } | ||
| if (!pdb.match(/^[a-z0-9]+$/i)) { return } |
There was a problem hiding this comment.
I think we should avoid relying on regex to check if a PDB code is valid. Instead, I think it would be a better idea to query PDB API endpoint to check if the PDB code exists ( https://data.rcsb.org/#rest-api )
For example, if I use 9fjj, the PDB code is valid, but has not yet been assigned to a structure on wwPDB: https://data.rcsb.org/rest/v1/core/entry/9ffj
Currently, I am able to submit 9fjj, which causes an endless loading loop that is not reported back to the user
There was a problem hiding this comment.
This is just a pre-filter to stop people from submitting anything that isn't a valid PDB. After this, it checks the ebi API and if it fails to find anything there it shows an error screen.
| export async function fetch_pdb(PDBCode) { | ||
| if (PDBCode == null) {return} | ||
| console.log("Fetching PDB ", PDBCode) | ||
| let pdb_url = `https://files.rcsb.org/download/${PDBCode.toUpperCase()}.pdb` |
There was a problem hiding this comment.
This breaks if I submit a non-existing PDB code, like 9fjj.
This PR address two issues #58 and #57.
This PR changes the front screen to look like this:
Which allows a user to get data from the PDB. While the MTZ functionality is there, the visualisation is not currently displayed due to issues interfacing with the Moorhen API.