Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to typescript #61

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Migration to typescript #61

merged 7 commits into from
Nov 10, 2023

Conversation

Dialpuri
Copy link
Collaborator

@Dialpuri Dialpuri commented Nov 1, 2023

Migration to typescript will allow for a more consistent and optimised developer experience. In this PR I have changed a lot of the main files to be in TS. This code should be in the main webserver branch going forward.

This PR requires a build and test.

@Dialpuri Dialpuri added the enhancement New feature or request label Nov 1, 2023
@Dialpuri Dialpuri requested a review from GABRAH November 1, 2023 17:40
@Dialpuri Dialpuri self-assigned this Nov 1, 2023
@Dialpuri
Copy link
Collaborator Author

Dialpuri commented Nov 1, 2023

This PR would close #60

Copy link
Collaborator

@GABRAH GABRAH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some minor typos remaining. Besides these minor typos, LGTM.

@GABRAH GABRAH self-requested a review November 10, 2023 14:58
@Dialpuri Dialpuri merged commit 4173198 into webapp Nov 10, 2023
@Dialpuri Dialpuri deleted the migration_to_typescript branch November 28, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants