-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added color swatches to README #24
Added color swatches to README #24
Conversation
Looking at it in photoshop, only a single pixel line of each colour block matches the hex code. It's essentially a gradient. That said, it gives a fair idea of what they are and is a better reference than it was before, so just The only other option is to throw something together in photoshop and throw this PSD into the @gmusic-utils/meta. I could recreate those buttons with a solid colour in no time if you're bothered enough to wait an hour or so. Let me know. |
It looks like we might have better luck with the |
It's a less intense gradient but it's still there =( https://img.shields.io/badge/%231ED760-%20%20%20-1ED760.svg?style=flat-squared |
If we do go the Photoshop route, it's prob best for the images to live in this repo itself or wherever we store the screenshot in the README:
In my repos, I typically make a https://github.com/twolfson/google-music-electron/tree/2.9.0/docs Meta is more for the |
I think the shields are probably fine. Like I say, it's just a reference and the hex codes are there. I doubt anyone will pull us up on the fact it doesn't default to the exact shade of green they were expecting from the visualisation 😄 |
Heh, here's to hoping 🍀 Going to wait on @MarshallOfSound before taking any actions on landing this PR (not sure I even can on |
LGTM 👍 I really need to give you guys NPM perms 😄 |
@MarshallOfSound Can you land/release this since I don't have |
I just added you on NPM along with @chrismou |
What's the release process? It looks like: npm version
# For example: `npm version patch` to bump patch version |
Yep, literally just npm version patch
npm publish Then don't forget to git push && git push --tags |
Cool, I will link the comment on #3 |
This has been merged/released in |
While discussing #17 I was getting frustrated at not having a good point of reference for what colors were which in the UI. To resolve this, I have added color swatches to the README.
I wanted to use HTML with
style="background"
or SVG but it looks like GitHub scrubs those. Thankfully, I was able to find a workaround via Shields.io (a badge service).In this PR:
/cc @gmusic-utils/gmusic-theme-js