Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpu_map.h #120

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from
Open

Update cpu_map.h #120

wants to merge 1 commit into from

Conversation

manikandan00
Copy link

No description provided.

@drf5n
Copy link

drf5n commented Apr 10, 2022

This won't work right:

  #define STEP_DDR      DDRA
  #define STEP_PORT     PORTA
  #define STEP_PIN      PINA
  #define X_STEP_BIT    54 // MEGA2560 Digital Pin 24
  #define Y_STEP_BIT    60// MEGA2560 Digital Pin 25
  #define Z_STEP_BIT    4 // MEGA2560 Digital Pin 26

The bits should be within the range 0-7 of the port, not the pin numbers.

For instance, on the mega digital pin 24 is PA2 per https://www.electronicshub.org/arduino-mega-pinout/ so it's port A, bit 2, and won't work as PORTA bit 54

@fra589
Copy link

fra589 commented Apr 10, 2022

I confirm that it will not work.
Moreover, you should not make a pull request for a modification that only interests you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants