Fixes bugged run(expr) (#2023) by adding run_cb(expr, callback) and run_wait(expr)
#2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cumentation for `run_cb(...)` and `run_wait(...)` and changed documentation for `run(...)`
Oxtaly
changed the title
run(expr). Adds run_cb(expr, callback) and run_wait(expr)run(expr) (#2023) by adding run_cb(expr, callback) and run_wait(expr)
|
I explained what the issue is about in the bug report in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2023 by adding
run_cb(expr, callback)andrun_wait(expr)functions that cover the previous return value use cases forrun(expr)More details and information in the committed Auxiliary.md
This also adds an error callback along with a setter
setErrorCallbackin SnoopyCommandSource to work with errors from the CommandSourceStack sendFailure being called after the resultConsumer fromwithCallbackor being called too early with resultConsumer not being triggeredI've tried to follow the code practices and indentation of the project but I'm still new to contributing to open source so apologies if it doesn't match perfectly