Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notable contribution template #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add notable contribution template #22

wants to merge 1 commit into from

Conversation

Kouteki
Copy link

@Kouteki Kouteki commented Nov 1, 2024

Add

  • Simple issue template
  • Notable contribution template

@Kouteki Kouteki self-assigned this Nov 1, 2024
@@ -0,0 +1,6 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the advantage of having such template?

@@ -0,0 +1,62 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use PRs only for notable contributions and discussions about their relevance.

A notable contribution should consist of a clear and concise commit title, ideally a single explicit line. Sometimes, it may need to include several links, but the main description should be in the actual contributions, such as the PR in the monorepo. A notable contribution entry here should not be the place where we spend too much time explaining why we believe it is significant.

If we want discussions, they can occur on the PR discussion page.

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until someone convince me why an issue-based approach might be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants