[BatchExchangeViewer] allow to fetch balances #540
Conversation
| @@ -1,6 +1,8 @@ | |||
| pragma solidity ^0.5.0; | |||
| pragma experimental ABIEncoderV2; | |||
There was a problem hiding this comment.
I don’t know if this is supported by current versions of web3 and ethabi and hence ethcontract. I’ll have to check.
There was a problem hiding this comment.
Let me know. If it's supported I'd love to refactor the orderbook fetching to also return list of structs instead of byte arrays (only in the Viewer contract though as we don't want experimental features in the core contract).
There was a problem hiding this comment.
I will go ahead and merge this now. As we are not depending on it yet it shouldn't cause any incompatibilities and we can change it later on if we need a different encoding for ethcontracts
There was a problem hiding this comment.
Any news on the support check @nlordell ?
There was a problem hiding this comment.
Sorry, forgot to update here. No this is currently not supported by either web3 crate or ethcontract 😢
That being said, adding support is feasible. I can take a look at doing this later in the week.
There was a problem hiding this comment.
Does this mean even the other methods cannot be deserialized or only the ones that would be returning a struct? I don't know if ABIEncoderV2 changes the encoding for "traditional" return types as well.
fleupold
force-pushed
the
viewer_balances
branch
from
ee926ac
to
3357a0e
Compare
This PR adds a method to get all balances of tokens listed in the exchange for a given user (this excludes pathological tokens which the user deposited without listing them).
It uses the experimental ABI encoder which allows nicely structured return values (instead of returning bytes or implicitly aligned arrays).
Unfortunately we cannot give accurate estimates of how much of a token is actually withdrawable (we have to take the requested amount which could be infinitely high cf. #539)
Test Plan
unit test + deploying this on rinkeby and running: