feat: moves IDecryptionVerifier out of E3Program / IComputeProvider

[auryn-macmillan]

Summary by CodeRabbit

• New Features

  • Introduced a new method for setting decryption verifiers, enhancing security and validation processes.
  • Updated validation methods to focus solely on encryption schemes and input validation.

• Bug Fixes

  • Simplified error handling for computation requests, improving clarity and functionality.

• Chores

  • Updated package version to reflect the latest changes and improvements.

• Tests

  • Refactored test cases to align with the new decryption verifier functionality, ensuring robust validation and error handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes primarily involve a transition from managing encryption schemes to managing decryption verifiers within the Enclave contract. Key functions and mappings have been updated to reflect this shift, including renaming and altering return types. The IE3Program interface has also been simplified by removing the IDecryptionVerifier from the validate function. Corresponding updates were made to the testing suite to ensure that the new functionalities are correctly implemented and validated.

Changes

Files	Change Summary
packages/evm/contracts/Enclave.sol	The Enclave contract now manages decryption verifiers instead of encryption schemes. Functions and mappings have been renamed and updated to reflect this change, including setDecryptionVerifier and getDecryptionVerifier.
packages/evm/contracts/interfaces/IE3Program.sol	The validate function in IE3Program has been modified to remove the IDecryptionVerifier return type, simplifying its output to only include bytes32 encryptionSchemeId and IInputValidator.
packages/evm/contracts/test/MockE3Program.sol	The MockE3Program contract has updated its import statements and the getProgramDetails function to exclude IDecryptionVerifier, focusing on returning only bytes32 encryptionSchemeId and IInputValidator.
packages/evm/package.json	The package version for @gnosis-guild/enclave has been updated from 0.0.2 to 0.0.3, indicating a new release.
packages/evm/test/Enclave.spec.ts	The test suite has been refactored to accommodate the new decryption verifier functionality, updating tests for setDecryptionVerifier and getDecryptionVerifier, and ensuring proper validation and event emissions.

Possibly related PRs

• Move Compute Provider validation and coordination to the E3Program contract #45: The changes in the Enclave contract regarding the removal of compute provider management and the update of error handling are related to the main PR's focus on modifying the Enclave contract's functionality, particularly in how it handles validation and verification processes.

Suggested reviewers

• ryardley
• nginnever
• cristovaoth
• hmzakhalid

🐰 In the burrow where bunnies play,
Decryption verifiers lead the way.
With schemes of old now set aside,
New paths of validation we do ride.
Hopping through code, so bright and clear,
A leap for change, let’s give a cheer! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.