-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use Persistable containers #189
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
c494e97
to
198fc6f
Compare
This is a refactor I have been thinking about for a while but was now instigated because we need to add yet another set of data synchronization traits to manage the libp2p keys within the context of the p2p actor.
Please read the rational and explanation of the persistence mechanisms and how they have grown with this project
This introduces an in memory data container that automatically sync with persistence so that the business logic can remain persistence ignorant and removes much of the overhead and boilerplate introduced by the
Snapshot
andCheckpoint
traits.