Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSKeyValueObserving: Implement setKeys:triggerChangeNotificationsForDependentKey: #489

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

NSKeyValueObserving: Implement setKeys:triggerChangeNotificationsForDependentKey: #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8889e7e
NSKVOSupport: Implement legacy KVO API
hmelder Feb 4, 2025
d1812ef
NSKVOSupport: Unit tests for the legacy API
hmelder Feb 4, 2025
c76d052
Update ChangeLog
hmelder Feb 4, 2025
71c5bb8
GCC does not support ivars in implementation block
hmelder Feb 4, 2025
2060863
Mark as hopeful on GCC
hmelder Feb 4, 2025
66b3ca6
NSKVOSupport: Conditionally exclude deprecated KVO API
hmelder Feb 4, 2025
d6b52c3
Add --disable-legacy flag and GS_LEGACY preprocessor define
hmelder Feb 4, 2025
844893a
Regenerate configure.ac
hmelder Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
2025-02-04 Hugo Melder <[email protected]>

* Source/NSKVOSupport.m:
* Tests/base/NSKVOSupport/legacy.m:
Implements the setKeys:triggerChangeNotificationsForDependentKey: class
method. Please do not use it. It is fundamentally broken, and requires
the object's meta class to hold additional state.
Keys from this class method are the last resort when retrieving
dependencies via keyPathsForValuesAffectingValueForKey:.
This aligns with the implementation in Foundation.

2025-01-04 Richard Frith-Macdonald <[email protected]>

* Headers/Foundation/NSRegularExpression.h:
Expand Down
1 change: 1 addition & 0 deletions Headers/GNUstepBase/GSConfig.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ typedef struct {
#define GS_HAVE_NSURLSESSION @GS_HAVE_NSURLSESSION@
#define GS_HAVE_OBJC_ROOT_CLASS_ATTR @GS_HAVE_OBJC_ROOT_CLASS_ATTR@
#define GS_USE_WIN32_THREADS_AND_LOCKS @HAVE_WIN32_THREADS_AND_LOCKS@
#define GS_LEGACY @GS_LEGACY@

#ifndef __has_include
# define __has_include(x) 0
Expand Down
Loading
Loading