Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job metrics #657

Closed
wants to merge 9 commits into from
Closed

Job metrics #657

wants to merge 9 commits into from

Conversation

gorodet-sky
Copy link
Contributor

What does this do?

Add interface for collect jobs execution metrics: counter, time elapsed

Which issue(s) does this PR fix/relate to?

Resolves #317

List any changes that modify/break current functionality

Have you included tests for your changes?

Yes, tests for counter was added

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

  • It seems to me that you can add a test for elapsed time, but I don’t know how to do it nice
  • In the future I want to make a metrics implementation for Prometheus in a separate repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add Metrics For Jobs
1 participant