More compress options #310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rektide
force-pushed
the
more-compress-options
branch
from
c74767f to
49a5891
Compare
obbardc
requested changes
Feb 22, 2022
| log.Printf("Compressing to %s\n", outfile) | ||
| return debos.Command{}.Run("Packing", "tar", tarOpt, outfile, | ||
| return debos.Command{}.Run("Packing", "tar", "cf", compressOpt outfile, |
There was a problem hiding this comment.
Nit: no comma between arguments
|
If we opt for libarchive (see #316) we could transparently support these formats, without adding extra code to debos. It's a very tempting, but bear in mind, I'm not sure if my initial idea will be accepted. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 12, 2022
282: actions: overlay: Log using action log functions r=obbardc a=obbardc Currently the overlay action prints directly to stdout, which ends up not following the standard output format the other actions follow. Let's clean this up by using the action's existing logging functions rather than printing directly to stdout. Signed-off-by: Christopher Obbard <[email protected]> 310: More compress options r=obbardc a=rektide Add `zstd`, `lzop`, `lzma`, `lzip` options. Add `auto` for pack. Co-authored-by: Christopher Obbard <[email protected]> Co-authored-by: rektide de la faye <[email protected]>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Oct 12, 2022
310: More compress options r=obbardc a=rektide Add `zstd`, `lzop`, `lzma`, `lzip` options. Add `auto` for pack. Co-authored-by: rektide de la faye <[email protected]>
|
Build failed: |
|
@rektide Can you rebase onto latest main & fix the conflicts ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
zstd,lzop,lzma,lzipoptions. Addautofor pack.