feat: add ErrorWithDetail #228
Open
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanhitt
force-pushed
the
ErrorWithDetail
branch
from
e1b10ce
to
85461e3
Compare
|
@EwenQuim should I update the docs? |
dylanhitt
force-pushed
the
ErrorWithDetail
branch
from
8ec3821
to
8b4c4df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225
Adds
ErrorWithDetailinterface to allow for response of detail. This is similar to the older with Info. The motivation for this is the fact that we use the detail option in theslog.Errorin the default error handler as well as in theHTTPError.Error()func. Maybe we should default into something as well in the case where the user doesn't supply it.If this is acceptable I will update the docs now as well.