Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more prometheus metrics #33307

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TheFox0x7
Copy link
Contributor

@TheFox0x7 TheFox0x7 commented Jan 16, 2025

Adds http tracking metrics, cache latency histogram, hit/miss counter for cache and counters for migration success/fail and currently running ones.

gitea_issues_open and gitea_issues_closed are deprecated for labels on gitea_issues

Closes: #14724


  • more metrics
  • tests
  • http_route has things like /favicon.ico/favicon.ico which do not look correct. Why? No idea but it stopped happening
  • tune buckets for histograms.

List of added metrics:
gitea_repository_inflight_migrations
gitea_repository_migrations{result: success/fail}
gitea_cache_response{state: hit/miss}
gitea_cache_latency
http_server_response_body_size{http_request_method, http_response_status_code, http_route}
http_server_request_body_size{http_request_method,http_response_status_code,http_route}
http_server_request_duration{http_request_method,http_response_status_code,http_route}
http_server_active_requests{http_request_method}

Suggestions for more are welcome.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 16, 2025
@TheFox0x7 TheFox0x7 force-pushed the prometheus-reorganization branch from cc06fe3 to 28615e2 Compare January 16, 2025 22:40
@TheFox0x7 TheFox0x7 force-pushed the prometheus-reorganization branch 2 times, most recently from 46424ca to 2f86823 Compare January 17, 2025 23:09
@TheFox0x7 TheFox0x7 force-pushed the prometheus-reorganization branch from 2f86823 to 056a308 Compare January 23, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/dependencies modifies/go Pull requests that update Go code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose more informations on /metrics
3 participants