Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6372] Fixed nullable constraint bug for columns during auto migration #7269

Merged
merged 10 commits into from
Nov 14, 2024

Conversation

wookie0
Copy link
Contributor

@wookie0 wookie0 commented Nov 7, 2024

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

Fix nullable constraint bug for columns during auto migration.

User Case Description

TBD.

Copy link
Member

@a631807682 a631807682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests?

Copy link
Contributor

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@wookie0
Copy link
Contributor Author

wookie0 commented Nov 7, 2024

@a631807682 @daheige
I did add test case in the previous built test function.
But some checks were not successful, I saw the CI log. But I can't find what problem is. I think test code I added is not cause. any help??

+) Also, test failed in master branch at local env.

@a631807682
Copy link
Member

a631807682 commented Nov 8, 2024

@a631807682 @daheige I did add test case in the previous built test function. But some checks were not successful, I saw the CI log. But I can't find what problem is. I think test code I added is not cause. any help??

+) Also, test failed in master branch at local env.

Fixed by go-gorm/sqlserver#134

Upgrade gorm.io/driver/sqlserver to v1.5.4

@wookie0
Copy link
Contributor Author

wookie0 commented Nov 8, 2024

@a631807682
Nice! Everything works perfectly.
Thanks!!

@jinzhu jinzhu merged commit b0d70a2 into go-gorm:master Nov 14, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants