[bugfix] Allow subdomain to end with uppercase letter #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
reDomain
regex currently returns ErrDomain errors foris.Domain
on values that should be valid, ex.ABC.com
regex for subdomain values currently allows lower & upper case alpha-num for beginning and optional middle chars, but won't match if value is longer than one char and ends with upper case, ex.
aBc.com
is valid butabC.com
returnsErrDomain
Reference
from https://github.com/go-ozzo/ozzo-validation/blob/master/is/rules.go#L246-L249:
Solution
updated to include uppercase letters in relevant part of the
reDomain
regex, which is in line with the stackoverflow answer already linked in the above referenced code comments