Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go modules, youmark/pkcs8 #209

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Update go modules, youmark/pkcs8 #209

merged 2 commits into from
Jul 30, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jul 29, 2024

4 years of improvements arrived.

@paskal paskal requested a review from umputun as a code owner July 29, 2024 00:26
@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10136001936

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.371%

Totals Coverage Status
Change from base Build 10102003918: 0.0%
Covered Lines: 2582
Relevant Lines: 3097

💛 - Coveralls

@paskal paskal force-pushed the paskal/update_pkcs8 branch from 8e7b651 to 1fa8182 Compare July 29, 2024 00:29
@paskal
Copy link
Collaborator Author

paskal commented Jul 29, 2024

I have no idea why test started failing but I can't reproduce it reliably enough locally to fix it. Something is off in the CI.

@paskal paskal force-pushed the paskal/update_pkcs8 branch from 1fa8182 to b591b6a Compare July 29, 2024 23:50
@paskal
Copy link
Collaborator Author

paskal commented Jul 29, 2024

Now it's good to go, I found where testing.T was used after the test termination.

@umputun umputun merged commit d126824 into master Jul 30, 2024
9 checks passed
@umputun umputun deleted the paskal/update_pkcs8 branch July 30, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants