Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Discord OAuth2 Provider #223

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Conversation

mgkbadola
Copy link
Contributor

@mgkbadola mgkbadola commented Oct 2, 2024

Added login support for Discord. If this is approved and merged, I would like to add it's its support to Remark42 (love that service).

A request: Since I am currently participating in Hacktoberfest, if this PR is to be merged, kindly add the label hacktoberfest-accepted to it. Many thanks!

@mgkbadola mgkbadola requested a review from umputun as a code owner October 2, 2024 18:33
@umputun umputun requested a review from paskal October 2, 2024 18:35
@umputun
Copy link
Member

umputun commented Oct 2, 2024

Thanks. I don't see anything wrong with this PR. @paskal - can you please take a look and double-check?

@umputun
Copy link
Member

umputun commented Oct 2, 2024

@mgkbadola - pls fix the linter issue, look like a public method without a comment

@mgkbadola
Copy link
Contributor Author

mgkbadola commented Oct 2, 2024

@mgkbadola - pls fix the linter issue, look like a public method without a comment

on it 👍🏽 done

@paskal
Copy link
Collaborator

paskal commented Oct 2, 2024

Thanks, will check and test shortly. Could you please add it to the v2 as well?

@coveralls
Copy link

coveralls commented Oct 2, 2024

Pull Request Test Coverage Report for Build 11195676729

Details

  • 21 of 23 (91.3%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 83.344%

Changes Missing Coverage Covered Lines Changed/Added Lines %
provider/providers.go 19 21 90.48%
Totals Coverage Status
Change from base Build 11078013402: 0.06%
Covered Lines: 2612
Relevant Lines: 3134

💛 - Coveralls

Copy link
Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good and works, but you need to drop email retrieval as the rest of the providers don't request any information not required for the unique user identification, and email is an extra information.

You can use umputun/remark42@53e9c98 as a reference when preparing changes for Remark42, just please don't forget to add discord.svg file which is not present in the commit: I've tested the auth with facebook icon.

provider/providers.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@paskal
Copy link
Collaborator

paskal commented Oct 3, 2024

According to the rules:

For your pull requests to be accepted, the request must either be merged, have the Hacktoberfest-accepted label, or have an overall approving review on GitHub.

I think this PR will be counted once merged.

@badolamgk
Copy link
Contributor

Hey/Privyet @paskal
I have done the required changes. Thanks for reviewing and providing reference for Remark42.

_example/main.go Outdated Show resolved Hide resolved
@badolamgk
Copy link
Contributor

Hey @umputun

Let me know if there are any other changes required on my end. Cheers.

@badolamgk
Copy link
Contributor

For the below command,

go test -timeout=60s -v -race -p 1 -covermode=atomic ./...

Test cases passing on my workstation, attaching logs here.

@umputun umputun merged commit 78537e6 into go-pkgz:master Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants