-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Discord OAuth2 Provider #223
Conversation
Thanks. I don't see anything wrong with this PR. @paskal - can you please take a look and double-check? |
@mgkbadola - pls fix the linter issue, look like a public method without a comment |
|
Thanks, will check and test shortly. Could you please add it to the v2 as well? |
Pull Request Test Coverage Report for Build 11195676729Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good and works, but you need to drop email retrieval as the rest of the providers don't request any information not required for the unique user identification, and email is an extra information.
You can use umputun/remark42@53e9c98 as a reference when preparing changes for Remark42, just please don't forget to add discord.svg file which is not present in the commit: I've tested the auth with facebook icon.
According to the rules:
I think this PR will be counted once merged. |
Hey/Privyet @paskal |
Hey @umputun Let me know if there are any other changes required on my end. Cheers. |
For the below command, go test -timeout=60s -v -race -p 1 -covermode=atomic ./... Test cases passing on my workstation, attaching logs here. |
Added login support for Discord. If this is approved and merged, I would like to add
it'sits support to Remark42 (love that service).A request: Since I am currently participating in Hacktoberfest, if this PR is to be merged, kindly add the label
hacktoberfest-accepted
to it. Many thanks!