Fix order submission for single leg orders #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting strange errors and took a while to debug (error handling should probably expose the api response for easier debugability) some of the issues:
POST /accounts/{accountNumber}/orders
returns a201
response code to indicate success. (see doc)LegTemplate
was causing issuesI've changed:
sonic.Marshal
(as it's used in other places in this codebase) instead of fmt.Sprintf .SingleLegOrder
to be an int to conform with the api specHere is the order submission request body before and after these updates:
Before:
after:
🍻