Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo of 内蔵 #151

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix typo of 内蔵 #151

merged 1 commit into from
Jul 26, 2024

Conversation

shogo82148
Copy link
Contributor

"内臓" and "内蔵" look similar but have completely different meanings in Japanese.

  • 内臓: visceral organ; viscus; viscera
  • 内蔵: built-in

In this case, we should use "内蔵"; the original English sentence is "Built-in Best Practice".


内臓 は胃、腸、肝臓などの臓器を表す単語です。
一方、内蔵 は「あるものが内部に別のものを納め持っていること」です。
原文は"Built-in"なので、対応する訳語としては「内蔵」のほうが適切です。

"内臓" and "内蔵" look similar but have completely different meanings in Japanese.

- 内臓: visceral organ; viscus; viscera
- 内蔵: built-in

In this case, we should use "内蔵"; the original English sentence is "Built-in Best Practice".
@tchssk
Copy link
Member

tchssk commented Jul 26, 2024

You are right. Thank you for the fix.

@tchssk tchssk merged commit e56f4ca into goadesign:master Jul 26, 2024
@tchssk
Copy link
Member

tchssk commented Jul 26, 2024

Error: google-github-actions/auth failed with: gitHub Actions did not inject $ACTIONS_ID_TOKEN_REQUEST_TOKEN or $ACTIONS_ID_TOKEN_REQUEST_URL into this job. This most likely means the GitHub Actions workflow permissions are incorrect, or this job is being run from a fork. For more information, please see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

Publish workflow failed. Could you please check it? @raphael

@tchssk
Copy link
Member

tchssk commented Jul 26, 2024

The publish workflow for master branch was successful and https://goa.design was updated. Nothing needed to be fixed.

@raphael
Copy link
Member

raphael commented Jul 28, 2024

Thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants