Streaming Interceptors #3641
Open
Streaming Interceptors #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrapping streaming methods
…plied; import the correct user types packages when rendering service_interceptors.go; fix an ancient typo
…dpoint field from goa.InterceptorInfo struct since it is redundant with the next goa.Endpoint parameter sent to interceptors
…thod with interceptors even if they do not apply
raphael
reviewed
Feb 2, 2025
| {{- range .WrappedClientStreams }} | ||
|
|
||
| {{ comment (printf "wrapped%s is a client interceptor wrapper for the %s stream." .Interface .Interface) }} | ||
| type wrapped{{ .Interface }} struct { |
There was a problem hiding this comment.
Might be nice to move the type definition to the top of the file
| @@ -9,8 +9,10 @@ type ( | |||
| Service string | |||
There was a problem hiding this comment.
We should update the struct header comment to reflect the changes
| @@ -9,8 +9,10 @@ type ( | |||
| Service string | |||
| // Name of method handling request | |||
| Method string | |||
| // Endpoint of request, can be used for retrying | |||
| Endpoint Endpoint | |||
| // Send is true if the request is a streaming Send | |||
There was a problem hiding this comment.
What's the rationale for these two fields? I could see Send helping differentiate between the initial request and the streaming request in the case of websocket but not sure I understand the point of Recv?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendWithContextandRecvWithContextmethods to the stream interfaces