-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add a chain type, wallet and plugin for the Zilliqa blockchain #171
(feat) Add a chain type, wallet and plugin for the Zilliqa blockchain #171
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!! :) Made some comments, let me know if they make sense! Happy to merge also and keep iterating over time.
Also let me know if you'd like to co-announce this, we can amplify from the GOAT and Crossmint twitters :)
Thank you very much for the fast & very helpful feedback! Will address and push an update shortly. |
1bcf5e2
to
78f1f5a
Compare
78f1f5a
to
9ff4e4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Interesting approach!
I made a comment on updating the viem wallet client, it shouldn't be needed.
Otherwise we can just merge and iterate from there :)
…goat-sdk#171) * (feat) Add a chain type, wallet and plugin for the Zilliqa blockchain * (fix) Remove outdated comment * (fix) Imperative descriptions for convert*Bech32 functions * (fix) Remove spurious accessors * Remove changes from viem package * update pnpm-lock * Add changeset --------- Co-authored-by: Agustin Armellini Fischer <[email protected]>
Relates to: #169
Background
What does this PR do?
This PR adds a wallet and plugin for the Zilliqa blockchain which can cope with both Zilliqa and EVM native addresses; once the approach is validated, we can start to add native (ZRC-2) token transactions and support for DEXes , etc.
Testing
There's a fork of Eliza which (with suitable
pnpm link
'ing) can do this at https://github.com/rrw-zilliqa/eliza/tree/rrw , but I can't submit that upstream until this is merged.Detailed testing results
(below is with Eliza via the code at https://github.com/rrw-zilliqa/eliza/tree/rrw )
Docs
I have updated the documentation accordingly.
For plugins
Discord username
_naranek