Avoid MustJoinedThreads query in ThreadDigest if not needed

goblint · Nov 30, 2023 · 05198f9 · 05198f9
1 parent 6dfc08f
commit 05198f9
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/analyses/commonPriv.ml b/src/analyses/commonPriv.ml
@@ -172,14 +172,13 @@ struct
     ThreadId.get_current ask
 
   let compatible (ask: Q.ask) (current: t) (other: t) =
-    let must_joined = ask.f Queries.MustJoinedThreads in
     match current, other with
     | `Lifted current, `Lifted other ->
-      if (TID.is_unique current) && (TID.equal current other) then
+      if TID.is_unique current && TID.equal current other then
         false (* self-read *)
       else if GobConfig.get_bool "ana.relation.priv.not-started" && MHP.definitely_not_started (current, ask.f Q.CreatedThreads) other then
         false (* other is not started yet *)
-      else if GobConfig.get_bool "ana.relation.priv.must-joined" && MHP.must_be_joined other must_joined then
+      else if GobConfig.get_bool "ana.relation.priv.must-joined" && MHP.must_be_joined other (ask.f Queries.MustJoinedThreads) then
         false (* accounted for in local information *)
       else
         true