Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AddressDomain for queries #1144

Merged
merged 21 commits into from
Sep 27, 2023
Merged

Use AddressDomain for queries #1144

merged 21 commits into from
Sep 27, 2023

Conversation

karoliineh
Copy link
Member

@karoliineh karoliineh commented Aug 29, 2023

Change query result from LS to AddressDomain for the following queries:

  • MustLockSet
  • MustProtectedVars (use VS instead)
  • Regions
  • EvalFunvar
  • MayBeTainted

The AD domain will not be used for the Regions query as of now, as some information would be lost by converting the values from cil expressions to Mval and back and as @vesalvojdani will hopefully eventually rewrite the region-analysis anyways.

Depends on #1142.

@karoliineh karoliineh added cleanup Refactoring, clean-up precision pr-dependency Depends or builds on another PR, which should be merged before labels Aug 29, 2023
@karoliineh karoliineh self-assigned this Aug 29, 2023
@karoliineh karoliineh marked this pull request as ready for review September 1, 2023 08:10
@sim642 sim642 added this to the v2.3.0 milestone Sep 11, 2023
src/analyses/base.ml Outdated Show resolved Hide resolved
src/analyses/modifiedSinceLongjmp.ml Outdated Show resolved Hide resolved
src/analyses/mutexAnalysis.ml Outdated Show resolved Hide resolved
Base automatically changed from queries-ad to master September 18, 2023 09:05
@sim642 sim642 removed the pr-dependency Depends or builds on another PR, which should be merged before label Sep 18, 2023
@karoliineh karoliineh requested a review from sim642 September 18, 2023 12:49
@sim642 sim642 merged commit f982bc9 into master Sep 27, 2023
16 checks passed
@sim642 sim642 deleted the queries-ad-cont branch September 27, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactoring, clean-up precision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants