Handle some special cases of bitand in invariant and Interval, DefExc, and Congruences
#1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
commented
Sep 10, 2023
michael-schwarz
force-pushed
the
issue_1153
branch
from
526e8e4 to
4d18300
Compare
sim642
reviewed
Sep 11, 2023
sim642
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles some special cases of
bitandwhere the second argument can be proven to be1or0, allowing for tracking the value of the LSB as suggested in #1153.This focuses on this special use case for now, there is lots of potential to become more precise in the remaining cases as well, but for now it is not clear to me where that would be beneficial (and to what extent).
(Though a principled handling of all bit-wise operations in all supported domains and comparison of the results before and after on sv-comp might be a good topic for a Bachelor's thesis)